chore(tracer): clean up span builder api #3227
Merged
+26
−100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3227 +/- ##
=======================================
+ Coverage 80.6% 80.8% +0.1%
=======================================
Files 128 128
Lines 23198 23156 -42
=======================================
- Hits 18719 18711 -8
+ Misses 4479 4445 -34 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bantonsson
force-pushed
the
ban/clean-up-spanbuilder
branch
from
0c92f07 to
45edb11
Compare
cijothomas
approved these changes
Nov 7, 2025
lalitb
approved these changes
Nov 7, 2025
This was
linked to
issues
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2886, #2743, #2744, #2745, #2746
Changes
Removes the following public fields and methods from the
SpanBuilder:trace_id,span_id,end_time,status,sampling_resultwith_trace_id,with_span_id,with_end_time,with_status,with_sampling_resultRemoves the following public hidden methods from the
SdkTracer:id_generator,should_sampleMerge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes